Sort attributes when building xml.dom.minidom.Element objects #415
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes failing tests on Python 3.8.1.
I have run all tests on Python 3.7.2 and Python 3.8.1.
#412 forced an alphanumeric ordering of attributes when generating XML from test cases. When attributes have namespaces, attribute order is different between these two cases:
assertPyxformXform
pyxform
in other contextsThis has been filed at #414. It means that #412 fixed the tests that use
assertPyxformXform
but not the tests that actually generate real XML output.This PR sorts attributes when building the true XML output.